Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSFS | A script for deploying NSFS on K8s #7330

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

romayalon
Copy link
Contributor

Explain the changes

  1. The following script deploys NSFS on K8s as described in https://github.com/noobaa/noobaa-core/wiki/NSFS-on-Kubernetes
  2. This script can be used also for cleanup of the deployed resources

Issues: Fixed #xxx / Gap #xxx

  1. Will update the wiki as well with more detailed

Testing Instructions:

  1. NSFS Deployment on K8s - bash /path/to/script/ deployment
  2. NSFS cleanup - bash /path/to/script/ cleanup
  • Doc added/updated
  • Tests added

src/cmd/deploy_nsfs.sh Show resolved Hide resolved
src/cmd/deploy_nsfs.sh Show resolved Hide resolved
src/cmd/deploy_nsfs.sh Outdated Show resolved Hide resolved
src/cmd/deploy_nsfs.sh Outdated Show resolved Hide resolved
src/cmd/deploy_nsfs.sh Outdated Show resolved Hide resolved
src/cmd/deploy_nsfs.sh Outdated Show resolved Hide resolved
src/cmd/deploy_nsfs.sh Outdated Show resolved Hide resolved
src/cmd/deploy_nsfs.sh Outdated Show resolved Hide resolved
src/cmd/deploy_nsfs.sh Outdated Show resolved Hide resolved
src/cmd/deploy_nsfs.sh Outdated Show resolved Hide resolved
src/cmd/deploy_nsfs.sh Outdated Show resolved Hide resolved
src/cmd/deploy_nsfs.sh Outdated Show resolved Hide resolved
src/cmd/deploy_nsfs.sh Show resolved Hide resolved
src/cmd/deploy_nsfs.sh Outdated Show resolved Hide resolved
src/cmd/deploy_nsfs.sh Outdated Show resolved Hide resolved
src/cmd/deploy_nsfs.sh Show resolved Hide resolved
Copy link
Contributor

@aspandey aspandey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did review it 3 days back but forgot to submit review changes. This review is mainly for code. I have not got the chance to try this script and provide my comment as user.

src/cmd/deploy_nsfs.sh Show resolved Hide resolved
src/cmd/deploy_nsfs.sh Outdated Show resolved Hide resolved
src/cmd/deploy_nsfs.sh Show resolved Hide resolved
src/cmd/deploy_nsfs.sh Outdated Show resolved Hide resolved
src/cmd/deploy_nsfs.sh Show resolved Hide resolved
src/cmd/deploy_nsfs.sh Show resolved Hide resolved
src/cmd/deploy_nsfs.sh Outdated Show resolved Hide resolved
src/cmd/deploy_nsfs.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@aspandey aspandey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me in code review.

Signed-off-by: Romy <romy2232@gmail.com>
@romayalon romayalon merged commit 1290d55 into noobaa:master Jun 28, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants