-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NSFS | A script for deploying NSFS on K8s #7330
Conversation
2793355
to
846a091
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did review it 3 days back but forgot to submit review changes. This review is mainly for code. I have not got the chance to try this script and provide my comment as user.
846a091
to
5e7e3a1
Compare
7dad033
to
2ab86e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me in code review.
Signed-off-by: Romy <romy2232@gmail.com>
2ab86e2
to
fb94e16
Compare
Explain the changes
Issues: Fixed #xxx / Gap #xxx
Testing Instructions: