Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tools fixes - s3cat, s3perf, http_speed #7337

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Tools fixes - s3cat, s3perf, http_speed #7337

merged 1 commit into from
Jun 13, 2023

Conversation

guymguym
Copy link
Member

@guymguym guymguym commented Jun 12, 2023 •
edited

Explain the changes

  1. fix s3cat put size fraction need rounding
  2. s3perf improve get object bench
  3. http_speed and tcp_speed use buffer pool
  4. cleanup tools output by removing console.log from top level module code
  5. fix nsfs and other cli tools that do not need db connection

Issues: Fixed #xxx / Gap #xxx

  1. Fixes Put of a small object(1KB) by s3cat --size does not stop #7315

Testing Instructions:

  1. NA

tangledbytes
tangledbytes reviewed Jun 12, 2023
View reviewed changes
src/tools/s3perf.js Outdated Show resolved Hide resolved
@guymguym guymguym force-pushed the guy-p8 branch 5 times, most recently from 09da940 to bd329c3 Compare June 13, 2023 10:30
liranmauda
liranmauda approved these changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@liranmauda liranmauda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
2 points:

  1. Seems like one function name (which was there and did not change) is not correct
  2. s3pref is not supporting versioning. I guess it has no meaning in supporting that, just wanted to point it out.

src/tools/s3perf.js Outdated Show resolved Hide resolved
@guymguym
tools fixes
070fcc8 
1. fix noobaa#7315 s3cat put size fraction need rounding

2. s3perf improve get object bench

3. http_speed and tcp_speed use buffer pool

4. cleanup tools output by removing console.log from top level module code

5. fix nsfs and other cli tools that do not need db connection

Signed-off-by: Guy Margalit <guymguym@gmail.com>
@guymguym guymguym merged commit 912a0ab into noobaa:master Jun 13, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangledbytes tangledbytes tangledbytes left review comments

@liranmauda liranmauda liranmauda approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Put of a small object(1KB) by s3cat --size does not stop
3 participants
@guymguym @liranmauda @tangledbytes