Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix block recall #7338

Merged
merged 1 commit into from
Jun 12, 2023
Merged

fix block recall #7338

merged 1 commit into from
Jun 12, 2023

Conversation

tangledbytes
Copy link
Member

Explain the changes

This PR:

  1. Adds an option which prevents block store from throwing MIGRATED error. Enabled by default. This is a temporary fix.
  2. Changes standalone.md to recommend increasing IO_TIMEOUTS (used in blockstore _request calls).
  • Doc added/updated
  • Tests added

@tangledbytes
fix block recall temporarily
6dc2db6 
Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com>
@tangledbytes tangledbytes changed the title fix block recall temporarily fix block recall Jun 12, 2023
guymguym
guymguym approved these changes Jun 12, 2023
View reviewed changes
Copy link
Member

@guymguym guymguym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@guymguym guymguym merged commit d9b10d6 into noobaa:master Jun 12, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guymguym guymguym guymguym approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tangledbytes @guymguym