Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bucket CORS move to config #7342

Merged
merged 1 commit into from
Jun 13, 2023
Merged

bucket CORS move to config #7342

merged 1 commit into from
Jun 13, 2023

Conversation

guymguym
Copy link
Member

Explain the changes

  1. bucket cors was hardcoded
  2. moved cors to config to allow modifying the behavior.
  3. no change to default runtime functionality
  4. next, we can consider moving it to be per bucket, and implement the s3 get/put_bucket_cors apis.

Issues: Fixed #xxx / Gap #xxx

  1. NA

Testing Instructions:

  1. NA
  • Doc added/updated
  • Tests added

@guymguym guymguym requested a review from romayalon June 13, 2023 16:06
@guymguym
bucket cors move to config
0197af3 
Signed-off-by: Guy Margalit <guymguym@gmail.com>
@guymguym guymguym changed the title bucket cors move to config - no change to runtime functionality bucket CORS move to config Jun 13, 2023
@guymguym
Copy link
Member Author

@romayalon Since this change is just a refactor, I am merging, but feel free to comment anytime and I'll fix as needed. Thanks

@guymguym guymguym merged commit bda6a11 into noobaa:master Jun 13, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romayalon romayalon Awaiting requested review from romayalon

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@guymguym