Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nsfs add config option to disable check bucket boundaries #7344

Merged
merged 1 commit into from
Jun 15, 2023
Merged

nsfs add config option to disable check bucket boundaries #7344

merged 1 commit into from
Jun 15, 2023

Conversation

guymguym
Copy link
Member

Explain the changes

  1. checking bucket boundaries can make a lot of system calls.
  2. adding a config option to manually disable it for testing its performance effect.

Issues: Fixed #xxx / Gap #xxx

  1. NA

Testing Instructions:

  1. set config.NSFS_CHECK_BUCKET_BOUNDARIES = false to disable.
  • Doc added/updated
  • Tests added

@guymguym guymguym added the NS-FS label Jun 15, 2023
@guymguym guymguym requested a review from romayalon June 15, 2023 06:39
@guymguym
nsfs add config option to disable check bucket boundaries
dcba0b6 
Signed-off-by: Guy Margalit <guymguym@gmail.com>
@guymguym guymguym merged commit 7d90230 into noobaa:master Jun 15, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romayalon romayalon romayalon approved these changes

Assignees
No one assigned
Labels
NS-FS size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@guymguym @romayalon