Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reverting check_miss for read_bucket_policy_info #7346

Merged
merged 1 commit into from
Jun 18, 2023
Merged

reverting check_miss for read_bucket_policy_info #7346

merged 1 commit into from
Jun 18, 2023

Conversation

jackyalbo
Copy link
Contributor

@jackyalbo jackyalbo commented Jun 15, 2023 •
edited

Explain the changes

  1. Reverting the 'cache_miss' option is causing bucketspace_fs to fail on mongo
  2. Instead of disabling the cache in general set the cache to disabled only in the tests by setting
    config.OBJECT_SDK_BUCKET_CACHE_EXPIRY_MS = 1 in coretest

Issues: Fixed #xxx / Gap #xxx

Testing Instructions:

  • Doc added/updated
  • Tests added

@jackyalbo jackyalbo marked this pull request as draft June 15, 2023 13:59
@jackyalbo jackyalbo force-pushed the jacky-fix4 branch 2 times, most recently from 3fb574a to 85c0b20 Compare June 18, 2023 13:27
@jackyalbo
reverting check_miss for read_bucket_policy_info
0e7b497 
Signed-off-by: jackyalbo <jacky.albo@gmail.com>
@jackyalbo jackyalbo marked this pull request as ready for review June 18, 2023 14:57
@jackyalbo jackyalbo merged commit 2dda457 into noobaa:master Jun 18, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romayalon romayalon romayalon approved these changes

@tangledbytes tangledbytes Awaiting requested review from tangledbytes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jackyalbo @romayalon