Support copy_object for log based replication #7349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achouhan09
force-pushed
the
log-repl
branch
2 times, most recently
from
7cd87fd
to
750a48f
Compare
achouhan09
force-pushed
the
log-repl
branch
2 times, most recently
from
811cfef
to
9834745
Compare
dannyzaken
reviewed
Jun 20, 2023
dannyzaken
reviewed
Jun 20, 2023
achouhan09
force-pushed
the
log-repl
branch
3 times, most recently
from
3647f9c
to
d8f11cb
Compare
achouhan09
force-pushed
the
log-repl
branch
2 times, most recently
from
ee3325f
to
7221560
Compare
dannyzaken
reviewed
Jul 3, 2023
dannyzaken
approved these changes
Jul 4, 2023
liranmauda
requested changes
Jul 5, 2023
src/api/replication_api.js
Outdated
| @@ -14,11 +14,11 @@ module.exports = { | |||
|
|
|||
| methods: { | |||
|
|
|||
| move_objects_by_type: { | |||
| copy_objects_by_type: { | |||
There was a problem hiding this comment.
If the copy_type is not a requirement anymore, I don’t see a reason to preserve the _by_type suffix.
Suggested change
| copy_objects_by_type: { | |
| copy_objects: { |
There was a problem hiding this comment.
@dannyzaken Can you pls confirm on this, I am not sure of it.
There was a problem hiding this comment.
I don't have a strong opinion on that. Either way will work
There was a problem hiding this comment.
Okay, I think for now we can keep it as same if in future we will be implementing other types of server side copy. Otherwise we can remove it @liranmauda wdyt its a very small change?
There was a problem hiding this comment.
I don't think we should change the api itself, just it's name.
There was a problem hiding this comment.
@liranmauda Done, PTAL.
dannyzaken
approved these changes
Jul 10, 2023
liranmauda
approved these changes
Jul 10, 2023
Signed-off-by: Aayush Chouhan <aayush.chouhan97@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes