Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NSFS | Check for GPFS lib path env var before calling gpfs functions #7355

Merged
merged 1 commit into from
Jun 21, 2023
Merged

NSFS | Check for GPFS lib path env var before calling gpfs functions #7355

merged 1 commit into from
Jun 21, 2023

Conversation

romayalon
Copy link
Contributor

@romayalon romayalon commented Jun 20, 2023 •
edited

Explain the changes

The Problem - Creating nsfs namespacestore using fs-backend=GPFS without having GPFS lib caused the endpoint pods to get into CLBO.

The Solution -

  1. Before reading GPFS xattr - instead of only checking the Namespacestore backend type, we will also check for the existance of the GPFS_DL_PATH environment variable.

Issues: Fixed #xxx / Gap #xxx

Testing Instructions:

  1. Install noobaa
  2. Create an NSFS Namespacestore of type GPFS
  3. Check if the endpoint pods crashing
  • Doc added/updated
  • Tests added

@romayalon romayalon requested a review from jackyalbo June 20, 2023 07:50
@cxhong
Copy link

cxhong commented Jun 20, 2023

The fixes is verified on my OCP4.13/ODF4.13/DAS cluster. LGTM. Thanks @romayalon
This is must fix for HPO, otherwise we can't run anything on ODF4.13 @nimrod-becker

guymguym
guymguym reviewed Jun 20, 2023
View reviewed changes
src/native/fs/fs_napi.cpp Outdated Show resolved Hide resolved
@romayalon romayalon force-pushed the romy-gpfs-lib-crash-fix branch 2 times, most recently from 7a15ecb to d61210d Compare June 21, 2023 07:41
guymguym
guymguym reviewed Jun 21, 2023
View reviewed changes
src/native/fs/fs_napi.cpp Outdated Show resolved Hide resolved
@romayalon
check for GPFS lib path before calling gpfs functions
9295e18 
Signed-off-by: Romy <romy2232@gmail.com>
@romayalon romayalon merged commit 9dd0bee into noobaa:master Jun 21, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guymguym guymguym guymguym approved these changes

@jackyalbo jackyalbo jackyalbo approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@romayalon @cxhong @guymguym @jackyalbo