Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete non existing object should not throw NoSuchKey but return successful response #7356

Merged
merged 1 commit into from
Jul 6, 2023
Merged

Delete non existing object should not throw NoSuchKey but return successful response #7356

merged 1 commit into from
Jul 6, 2023

Conversation

romayalon
Copy link
Contributor

@romayalon romayalon commented Jun 21, 2023 •
edited

Explain the changes

  1. Added conversion of BlobNotFound/NO_SUCH_OBJECT error to success on the namespace level as we do for other namespaces.
  2. Added unit tests

Issues: Fixed #xxx / Gap #xxx

  1. Fixed #S3 delete object should always return success even if not exists #7353

Testing Instructions:

  • Doc added/updated
  • Tests added

@romayalon romayalon requested a review from guymguym June 21, 2023 04:44
@romayalon romayalon mentioned this pull request Jun 21, 2023
Open
@pull-request-size pull-request-size bot added size/M and removed size/L labels Jun 29, 2023
@romayalon romayalon force-pushed the romy-fix-delete-object-success branch 3 times, most recently from 293c086 to a5af062 Compare June 29, 2023 11:26
@romayalon
delete non existing object should not throw
e773b0c 
Signed-off-by: Romy <romy2232@gmail.com>
@romayalon romayalon force-pushed the romy-fix-delete-object-success branch from a5af062 to e773b0c Compare July 6, 2023 07:11
@romayalon romayalon merged commit 23ce2fd into noobaa:master Jul 6, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackyalbo jackyalbo jackyalbo approved these changes

@guymguym guymguym Awaiting requested review from guymguym

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@romayalon @jackyalbo