Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fs_napi after #7358 - use ToBoolean to check for non falsy values #7359

Merged
merged 1 commit into from
Jun 22, 2023
Merged

Fix fs_napi after #7358 - use ToBoolean to check for non falsy values #7359

merged 1 commit into from
Jun 22, 2023

Conversation

guymguym
Copy link
Member

Explain the changes

  1. In Fix #7304 try to set TMFS trigger xattr but warn only on failure #7358 I introduced a bug that fails writes because in fs_napi we used to check if a key was provided in the options, but not if that key has a non-falsy value, meaning not undefined or null etc.

Issues: Fixed #xxx / Gap #xxx

  1. NA

Testing Instructions:

  1. Flows that use fs_napi writeFile such as backing_store_fs.
  • Doc added/updated
  • Tests added

@guymguym
Fix fs_napi after noobaa#7358 - use ToBoolean to check for non falsy …
d2ec478 
…values

Only cases where ToBoolean doesn't work well is for numbers that could be 0 (e.g uid/gid/mode).

Signed-off-by: Guy Margalit <guymguym@gmail.com>
@guymguym guymguym merged commit 83a2938 into noobaa:master Jun 22, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangledbytes tangledbytes tangledbytes approved these changes

@romayalon romayalon Awaiting requested review from romayalon

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@guymguym @tangledbytes