[TMFS] Address minors from #7313 & support auto second tier creation & assignment if configured #7360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tangledbytes
force-pushed
the
utkarsh-pro/add/support-bucket-tmfs-autoconf
branch
from
c6f4e4b
to
c68d17a
Compare
tangledbytes
force-pushed
the
utkarsh-pro/add/support-bucket-tmfs-autoconf
branch
4 times, most recently
from
8d5d5cc
to
1041bed
Compare
guymguym
reviewed
Jun 22, 2023
tangledbytes
force-pushed
the
utkarsh-pro/add/support-bucket-tmfs-autoconf
branch
from
1041bed
to
401eaac
Compare
Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com> add auto tier 2 creation & assignment to bucket if configured Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com> fix issues Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com> fix docs Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com> fix deepscan Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com> cleanup auto_setup_tier2 Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com>
tangledbytes
force-pushed
the
utkarsh-pro/add/support-bucket-tmfs-autoconf
branch
from
401eaac
to
995c7da
Compare
Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com> add auto tier 2 creation & assignment to bucket if configured Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com> fix issues Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com> fix docs Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com> fix deepscan Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com> cleanup auto_setup_tier2 Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com> cleanup auto_setup_tier2 and reduce agent_blocks_reclaimer log verbosity Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com>
guymguym
approved these changes
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
This PR:
TMFS_BUCKET_TIER2_AUTOCONFandBLOCK_STORE_FS_TMFS_ENABLEDare enabled. Created another config parameter instead of linking it toBLOCK_STORE_FS_TMFS_ENABLEDto provide slightly more control over behaviour hopefully helpful while debugging.PS: 2nd change was introduced accidentally as a result of creating a branch off my previous branch (which had the changes). I can split the PR into 2 different PRs or merge the 2 commits, I have no preference here.