-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CVE-2019-15597 - Implement new DF command instead of library function #7362
Conversation
lets add a unit test |
since df checks the available space on the whole file system, which I have no control over, I can't test the validity of the actual values. so instead I just check that the command returns a valid response and that no errors are thrown |
6c689bc
to
82d40ee
Compare
I have added try catch to df calls with file name since now the function throws if the file doesn't exist and does not just return a null value |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…tion Signed-off-by: nadav mizrahi <nadav.mizrahi16@gmail.com>
Explain the changes
Issues: Fixed #xxx / Gap #xxx
Testing Instructions: