NSFS | Versioning | Suspended Mode Delete Object

[shirady]

Explain the changes

1. Add NSFS Versioning Suspended mode to support delete-object operation.
2. Minor changes in comments and formatting in code lines related to NSFS | Versioning | Suspended Mode Put Object.
    

Issues: Gaps

1. In suspended mode changes we used only "safe" filesystem functions (safe_move, safe_unlink), later we might change it according to the specific case (we also don't have concurrency tests).
2. GPFS was not tested yet with these changes.
3. We currently don't keep XATTR_PREV_VERSION_ID updated in case there is a deletion of a specific version id or in case we delete an old null version from the .versions/ directory.
4. When we have a delete-object request we don't validate that it was requested from the bucket owner.
    

Testing Instructions:

Manual Tests:

1. Change the configuration of NSFS Versioning to be Enabled in file config.js and change config.NSFS_VERSIONING_ENABLED to true.
2. Deploy noobaa system on minikube (Based on the instructions here - the steps of ‘Build images’ and ‘Deploy noobaa’).
   Note: nb is an alias that runs the local operator from build/_output/bin (alias created by devenv).
3. Deploy NSFS on minikube (Based on the instructions here).
4. Use AWS CLI and use the put-object command (here is a link to their doc).
5. Set the bucket to versioning Enabled and put-object of another key (here is a link to their doc).
6. Set versioning to suspended and put versions of the same object that were uploaded before (steps 4 and 5).
7. Use AWS CLI and use the delete-object command (here is a link to their doc).
    
   While you add and delete objects to the bucket you can view the changes
8. Connect to the endpoint pod: kubectl exec -it [endpont-pod-name] -- bash.
9. Move to the bucket path (if you did it as written in the wiki it would be cd /nsfs/fs1/bucket-path/).
10. Use Linux commands to list the files (including hidden files), for example: ls -al.
     

Run Unit Tests:

1. In file src/test/unit_tests/sudo_index.js leave only require('./test_bucketspace_versioning'); (rest of test files  comment out).
2. From the core tab in the terminal run: make root-perm-test (You should see "140 passing" at the end of the output).
    

• Tests added: NSFS Versioning Suspended mode: delete-object (latest),  delete-object version-ID, and delete-objects (based on existing tests that we have in NSFS Versioning Enabled mode).