-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NSFS | Versioning | List Object Version - Support for Null Version #7371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vh05
requested changes
Jul 24, 2023
shirady
force-pushed
the
list-versions-nsfs
branch
2 times, most recently
from
July 31, 2023 11:59
3122545
to
7886d48
Compare
vh05
reviewed
Jul 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
I feel one more approval would be better
romayalon
reviewed
Aug 2, 2023
romayalon
reviewed
Aug 2, 2023
romayalon
reviewed
Aug 3, 2023
shirady
force-pushed
the
list-versions-nsfs
branch
from
August 6, 2023 12:56
f76c391
to
23f2553
Compare
romayalon
approved these changes
Aug 6, 2023
Signed-off-by: shirady <57721533+shirady@users.noreply.github.com>
shirady
force-pushed
the
list-versions-nsfs
branch
from
August 6, 2023 14:36
23f2553
to
6937ef9
Compare
vh05
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
Before this change when we had a version id of null the behavior was not expected, when I test it I saw:
_get_version_id_by_stat
to function outside of theNameSpaceFS
class.Issues: Gaps
Testing Instructions:
Manual Tests:
config.js
and changeconfig.NSFS_VERSIONING_ENABLED
totrue
.Note:
nb
is an alias that runs the local operator frombuild/_output/bin
(alias created bydevenv
).While you add objects to the bucket you can view the changes
kubectl exec -it [endpont-pod-name] -- bash
.cd /nsfs/fs1/bucket-path/
).ls -al
.Test stat error edge case (and no old_version edge case):
Status: When we have .versions directory and inside it only 1 null version, add an error after stat. Should list object version without null version.
Run Unit Tests:
src/test/unit_tests/sudo_index.js
leave onlyrequire('./test_bucketspace_versioning');
(rest of test files comment out).make root-perm-test
(You should see "144 passing" at the end of the output).