Fix INVALID_SCHEMA_DB objectstats ERRORS
#7373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guymguym
reviewed
Jul 3, 2023
Comment on lines
+77
to
+84
| // Ineffective and not needed in mongo | ||
| // | ||
| // This is a postgres hack, this allows us to | ||
| // initialize the counters if the fields are missing | ||
| upsert_fields: { | ||
| s3_usage_info: usage, | ||
| s3_errors_info: errors | ||
| } |
There was a problem hiding this comment.
Hey @dannyzaken - PTAL
I remember you said there is something to fix for upsert - is that in the direction you where thinking?
There was a problem hiding this comment.
This fix looks good. In general, I think we should get rid of upserts altogether since the way we implement it in Postgres is too complex. This will require changing our stats stores that still use it
There was a problem hiding this comment.
I agree, but we might still need upsert or at least an atomic find + insert (a transaction based wrapper maybe)?
Of course not as part of this PR, rather a separate PR addressing PG upserts.
dannyzaken
approved these changes
Jul 6, 2023
tangledbytes
force-pushed
the
utkarsh-pro/fix/boreas-mvp-19
branch
from
2464dee
to
ea12224
Compare
Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com>
tangledbytes
force-pushed
the
utkarsh-pro/fix/boreas-mvp-19
branch
from
ea12224
to
872ca7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
This PR fixes
INVALID_SCHEMA_DB objectstats ERRORSthat we encounter in our endpoints.The root cause for the issue was due to the fact that postgres (by default/without
COALASCE) does not create nested fields. This problem is being fixed in this PR via a hack field infindOneAndUpdate'soptionsparameter calledupsert_optionswhich creates the necessarily fields if the entry is new.Other solutions to the problem were also explored like:
upsertsbetter. Rejected due to potentially slow dev cycle.findOneAndUpdate. Works but doesn't works both theoretically and practically. Too many races. Rejected.Although the changes are kind of postgres specific and tested on postgres exclusively, I fully expect this to function well in mongo as well.