Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eslint | Remove Rule 'eol-last': 'off' #7374

Merged
merged 1 commit into from
Jul 4, 2023
Merged

eslint | Remove Rule 'eol-last': 'off' #7374

merged 1 commit into from
Jul 4, 2023

Conversation

shirady
Copy link
Contributor

@shirady shirady commented Jul 3, 2023

Explain the changes

  1. Remove rule 'eol-last': 'off'.
  2. Add all the files after running eslint --fix src.

Issues: Fixed #xxx / Gap #xxx

  1. Today we usually see when we don't add the end-of-line when we open a PR, and there are some reviewers that comment on it. Removing this rule would make us all add end-of-line while we work on the file.

Testing Instructions:

  1. eslint src
  • Doc added/updated
  • Tests added

@shirady shirady requested a review from liranmauda July 3, 2023 12:26
@shirady shirady requested a review from guymguym July 3, 2023 12:26
@shirady
remove rule 'eol-last': 'off' and add all the files after running esl…
3b1e47b 
…int --fix src

Signed-off-by: shirady <57721533+shirady@users.noreply.github.com>
@shirady shirady self-assigned this Jul 4, 2023
@shirady shirady merged commit c2dfacc into noobaa:master Jul 4, 2023
6 checks passed
@shirady shirady deleted the change-lint-newline branch July 4, 2023 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guymguym guymguym guymguym approved these changes

@liranmauda liranmauda Awaiting requested review from liranmauda

Assignees

@shirady shirady

Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shirady @guymguym