passing log candidates as batch for and copy and delete #7375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achouhan09
requested review from
dannyzaken,
tangledbytes,
a team and
nbecker-cibot
and removed request for
a team
achouhan09
changed the title
achouhan09
force-pushed
the
batch-repl
branch
3 times, most recently
from
83d50d5
to
787eb23
Compare
achouhan09
force-pushed
the
batch-repl
branch
3 times, most recently
from
7bfa145
to
e569d0e
Compare
achouhan09
force-pushed
the
batch-repl
branch
2 times, most recently
from
d4fb06e
to
f041762
Compare
dannyzaken
reviewed
Jul 13, 2023
achouhan09
force-pushed
the
batch-repl
branch
3 times, most recently
from
1f06e01
to
a4b5719
Compare
achouhan09
force-pushed
the
batch-repl
branch
3 times, most recently
from
7c08428
to
3d8f875
Compare
achouhan09
commented
Jul 24, 2023
| // if there is already a candidate for the same key, then we have a conflict | ||
| if (logs_for_key_time_map.has(log.time)) { | ||
| // If there is already a candidate for the same key, then we have a conflict | ||
| if (logs_for_key_time_map.has(log_time)) { |
There was a problem hiding this comment.
Hey @Utkarsh-pro
Just for information while writing the unit tests I checked that this condition is not working as expected because of strict comparison, we are comparing two different time objects here which put this condition to always false state. Updated the code with string comparison now working fine.
Pls let me know if you have any more thoughts. Thanks
achouhan09
force-pushed
the
batch-repl
branch
3 times, most recently
from
11534bd
to
7921081
Compare
dannyzaken
reviewed
Jul 26, 2023
achouhan09
force-pushed
the
batch-repl
branch
3 times, most recently
from
cf4191f
to
7b96749
Compare
achouhan09
force-pushed
the
batch-repl
branch
6 times, most recently
from
ab96dd8
to
66c4423
Compare
dannyzaken
reviewed
Aug 2, 2023
| for (const candidate of src_dst_objects_list) { | ||
| await this.process_candidate(src_bucket, dst_bucket, candidate); | ||
| const action = await this.process_candidate(candidate); |
There was a problem hiding this comment.
unless I missed anything, process_candidate doesn't need to be async and there is no reason to wait for it.
There was a problem hiding this comment.
yes right, no need to async updated the code. Thanks
achouhan09
force-pushed
the
batch-repl
branch
2 times, most recently
from
01e7594
to
4709a11
Compare
dannyzaken
approved these changes
Aug 3, 2023
Signed-off-by: Aayush Chouhan <aayush.chouhan97@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes