New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid logging an error message for an expected error #7376

Merged

dannyzaken merged 1 commit into noobaa:master from dannyzaken:danny-fixes

Jul 27, 2023

Contributor

dannyzaken commented Jul 5, 2023

Explain the changes

in test_store_validity, we try to delete a non-existing object to test the validity of the S3 details.
S3 returns an expected error which should not be printed to log. removed the message in case of NoSuchKey error

Issues: Fixed #xxx / Gap #xxx

Testing Instructions:

Doc added/updated
Tests added

pull-request-size bot added the size/S label

dannyzaken requested a review from romayalon

July 5, 2023 13:44

romayalon approved these changes

View reviewed changes

dannyzaken force-pushed the danny-fixes branch 4 times, most recently from dd61fa1 to e310a6f Compare

July 17, 2023 11:26

pull-request-size bot added size/M and removed size/S labels

dannyzaken force-pushed the danny-fixes branch 4 times, most recently from c63c302 to c9186e4 Compare

July 20, 2023 06:57


          avoid error message for expected s3 error

c108a42

Signed-off-by: Danny Zaken <dannyzaken@gmail.com>

dannyzaken force-pushed the danny-fixes branch from c9186e4 to c108a42 Compare

July 27, 2023 06:02

dannyzaken merged commit 7705904 into noobaa:master

6 of 7 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment