Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create bucket_diff util #7378

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Create bucket_diff util #7378

merged 1 commit into from
Jul 20, 2023

Conversation

liranmauda
Copy link
Contributor

Explain the changes

  1. Created bucket_diff
  2. Adding bucket_diff unit tests

Testing Instructions:

  1. run npx jest test_bucket_diff.test.js
  • Tests added

@liranmauda liranmauda requested a review from romayalon July 5, 2023 15:00
@liranmauda
Copy link
Contributor Author

As those are jest tests, should we move them into a directory or leave them next to the code they test 🤔
@romayalon WDYT?

@liranmauda liranmauda force-pushed the liran-bucket-diff-single-direction branch from f3bc93e to 6dcc0bd Compare July 6, 2023 09:06
@liranmauda
Copy link
Contributor Author

one more thought, should I move the version into the constructor?

@liranmauda liranmauda force-pushed the liran-bucket-diff-single-direction branch 6 times, most recently from f9c0eb4 to e89698e Compare July 12, 2023 13:46
romayalon
romayalon reviewed Jul 12, 2023
View reviewed changes
src/server/utils/bucket_diff.js Show resolved Hide resolved
src/server/utils/bucket_diff.js Show resolved Hide resolved
src/server/utils/bucket_diff.js Outdated Show resolved Hide resolved
src/server/utils/bucket_diff.js Outdated Show resolved Hide resolved
src/server/utils/bucket_diff.js Outdated Show resolved Hide resolved
src/server/utils/bucket_diff.js Show resolved Hide resolved
src/server/utils/bucket_diff.js Outdated Show resolved Hide resolved
src/server/utils/bucket_diff.js Outdated Show resolved Hide resolved
src/server/utils/bucket_diff.js Outdated Show resolved Hide resolved
src/server/utils/bucket_diff.js Outdated Show resolved Hide resolved
@liranmauda liranmauda force-pushed the liran-bucket-diff-single-direction branch 8 times, most recently from 3ee6e7b to 7a6b167 Compare July 16, 2023 12:00
@liranmauda liranmauda force-pushed the liran-bucket-diff-single-direction branch 2 times, most recently from 7502076 to ff71837 Compare July 19, 2023 12:52
romayalon
romayalon approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@romayalon romayalon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as we discussed, let's move the version flag to the constructor and let's merge

@liranmauda liranmauda force-pushed the liran-bucket-diff-single-direction branch from 846c34a to 54e0fe8 Compare July 19, 2023 15:24
@liranmauda
Create bucket_diff util
2a39b06 
- Created bucket_diff
- Adding bucket_diff unit tests

Signed-off-by: liranmauda <liran.mauda@gmail.com>
@liranmauda liranmauda force-pushed the liran-bucket-diff-single-direction branch from 54e0fe8 to 2a39b06 Compare July 20, 2023 06:47
@liranmauda liranmauda merged commit c14d6c3 into noobaa:master Jul 20, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romayalon romayalon romayalon approved these changes

Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@liranmauda @romayalon