Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config option to disable node io detention #7381

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

guymguym
Copy link
Member

@guymguym guymguym commented Jul 5, 2023

Explain the changes

  1. Backing store over TMFS have longer delays.
  2. Added config.NODE_IO_DETENTION_DISABLE that can be set true to allow keeping the nodes active and not get into detention.
  3. We already had config.NODE_IO_DETENTION_THRESHOLD that could be tweaked separately to shorten or zero the time that detention is applied, before it gets reset, but this still allows the node to enter detention and disconnect
  4. Cleaned 3 unused configs - LONG_GONE_THRESHOLD, SHORT_GONE_THRESHOLD, LONG_BUILD_THRESHOLD.
  5. Moved local constants from nodes_monitor to config, just in case we want to override it.

Issues: Fixed #xxx / Gap #xxx

  1. NA

Testing Instructions:

  1. NA

@guymguym guymguym added the TMFS label Jul 5, 2023
@guymguym guymguym requested review from dannyzaken, tangledbytes, a team and alphaprinz and removed request for a team July 5, 2023 20:41
Copy link
Contributor

@liranmauda liranmauda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Guy Margalit <guymguym@gmail.com>
@guymguym guymguym merged commit 5302d04 into noobaa:master Jul 6, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants