Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues with new df command #7383

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Fix issues with new df command #7383

merged 1 commit into from
Jul 10, 2023

Conversation

nadavMiz
Copy link
Contributor

@nadavMiz nadavMiz commented Jul 6, 2023

Explain the changes

  1. fix indentations
  2. remove the redundant check for stderr
  3. fix character typo

Issues: Fixed #xxx / Gap #xxx

Testing Instructions:

  • Doc added/updated
  • Tests added

@nadavMiz nadavMiz requested a review from liranmauda July 6, 2023 12:57
@pull-request-size pull-request-size bot added size/L and removed size/M labels Jul 9, 2023
@nadavMiz nadavMiz force-pushed the df-command-fixes branch 2 times, most recently from 3f99223 to aa456d2 Compare July 9, 2023 09:58
liranmauda
liranmauda approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@liranmauda liranmauda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nadavMiz
fix issues with new df command
92de4a8 
Signed-off-by: nadav mizrahi <nadav.mizrahi16@gmail.com>
@nadavMiz nadavMiz merged commit 53be237 into noobaa:master Jul 10, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liranmauda liranmauda liranmauda approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nadavMiz @liranmauda