Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

put_object_acl - continue even without canned acl which some clients require #7391

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

guymguym
Copy link
Member

Explain the changes

  1. The current put_object_acl code assumed that it should fail if a non canned acl was provided.
  2. However this caused clients to fail and not be able to continue.
  3. Instead we prefer to pass the info to the next layer of the namespaces and let it decide how to handle.
  4. Most namespaces will ignore if they do not support setting acl, which at least allows clients to continue.

Issues: Fixed #xxx / Gap #xxx

  1. NA

Testing Instructions:

  1. npm run nsfs .
  2. aws --endpoint http://localhost:6001 s3 cp package.json s3://logs/package.json
  3. aws --endpoint http://localhost:6001 s3api put-object-acl --bucket logs --key package.json --grant-read joe.shmoe

@guymguym guymguym added the S3-Compatibility S3 Compatibility and Namespace over AWS label Jul 11, 2023
@guymguym guymguym requested a review from romayalon July 11, 2023 06:45
…require

Signed-off-by: Guy Margalit <guymguym@gmail.com>
@guymguym guymguym merged commit 2bc60f0 into noobaa:master Jul 11, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S3-Compatibility S3 Compatibility and Namespace over AWS size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants