Makefile target to build linux executable in build container #7392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guymguym
added
the
Standalone
liranmauda
reviewed
Jul 11, 2023
liranmauda
reviewed
Jul 11, 2023
| @@ -0,0 +1,11 @@ | |||
| # This dockerfile exports just the single file executable from the built image. | |||
There was a problem hiding this comment.
Do we need 2 Dockerfiles?
if this is intended to be built using the makefile we can write it as an additional stage in executable.Dockerfile and in the make file use a target for building.
There was a problem hiding this comment.
I had this in the same dockerfile when I started, the problem is that when using docker build --output <dir> it seems to not save the cache because it only outputs the content to a directory, and I wanted to have a proper cache. So with an intermediate step that has a named image (noobaa-core-executable) the cache is saved and only the export step uses the --output flag.
Signed-off-by: Guy Margalit <guymguym@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
make executabletarget to build the noobaa-core single-executable (with pkg for now) for linux x86_64 inside a build container.Issues: Fixed #xxx / Gap #xxx
Testing Instructions:
make executable