Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Azure log credentials in update_external_connection #7394

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Support Azure log credentials in update_external_connection #7394

merged 1 commit into from
Jul 19, 2023

Conversation

Neon-White
Copy link
Contributor

@Neon-White Neon-White commented Jul 11, 2023 •
edited

Explain the changes

  1. Added support for the optional Azure log credentials in update_external_connection
  2. Fixed a bug in the Azure log iterator

@Neon-White Neon-White added the Compatibility-Azure Blob Compatibility and Namespace over Azure label Jul 11, 2023
@Neon-White Neon-White force-pushed the add-update-support-for-azure-log-creds branch 8 times, most recently from 7d2b7ac to 4a7a22f Compare July 19, 2023 07:37
@Neon-White Neon-White force-pushed the add-update-support-for-azure-log-creds branch from 4a7a22f to 9983930 Compare July 19, 2023 10:04
romayalon
romayalon reviewed Jul 19, 2023
View reviewed changes
src/server/system_services/account_server.js Outdated Show resolved Hide resolved
src/server/system_services/account_server.js Outdated Show resolved Hide resolved
src/server/system_services/account_server.js Outdated Show resolved Hide resolved
@Neon-White Neon-White force-pushed the add-update-support-for-azure-log-creds branch 2 times, most recently from dc11f4b to fcb9e90 Compare July 19, 2023 13:22
@Neon-White Neon-White mentioned this pull request Jul 19, 2023
Merged
@Neon-White
Support Azure log credentials in update_external_connection
90f021d 
Signed-off-by: Ben <belimele@redhat.com>
@Neon-White Neon-White force-pushed the add-update-support-for-azure-log-creds branch from fcb9e90 to 90f021d Compare July 19, 2023 15:54
@Neon-White Neon-White merged commit b78abef into noobaa:master Jul 19, 2023
7 checks passed
@Neon-White Neon-White deleted the add-update-support-for-azure-log-creds branch July 19, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannyzaken dannyzaken dannyzaken approved these changes

@romayalon romayalon romayalon approved these changes

@tangledbytes tangledbytes Awaiting requested review from tangledbytes

Assignees
No one assigned
Labels
Compatibility-Azure Blob Compatibility and Namespace over Azure size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Neon-White @dannyzaken @romayalon