Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating to AWS SDK V3 | Add Packages client-s3, node-http-handler #7397

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

shirady
Copy link
Contributor

@shirady shirady commented Jul 13, 2023

Explain the changes

  1. Changes after:
  • npm install @aws-sdk/client-s3
  • npm install @aws-sdk/node-http-handler
  • npm update

Issues: Fixed #xxx / Gap #xxx

  1. none

Testing Instructions:

  1. none
  • Doc added/updated
  • Tests added

@shirady shirady requested a review from liranmauda July 13, 2023 05:24
@shirady shirady self-assigned this Jul 13, 2023
npm install @aws-sdk/client-s3
npm install @aws-sdk/node-http-handler

Signed-off-by: shirady <57721533+shirady@users.noreply.github.com>

npm update changes

Signed-off-by: shirady <57721533+shirady@users.noreply.github.com>
@shirady shirady force-pushed the migrate-aws-sdk-add-packages branch from 81e8322 to 1a9c893 Compare July 13, 2023 07:24
Copy link
Contributor

@liranmauda liranmauda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirady shirady merged commit e8b7ab3 into noobaa:master Jul 13, 2023
7 checks passed
@shirady shirady deleted the migrate-aws-sdk-add-packages branch July 16, 2023 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants