Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abide by RFC 7230 for S3 HTTP headers #7408

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

tangledbytes
Copy link
Member

@tangledbytes tangledbytes commented Jul 24, 2023

Explain the changes

Replacing the . character with __dot__. This is done to ensure that we abide by RFC 7230 (section 3.2).

Issues with this approach?

  1. If an application wants to consume this header then they will have to know how to "decode" them.
  2. Increases the length of the header by 6 chars so we can encode fewer of them now.

Issues: Fixed #xxx / Gap #xxx

Attempts to fix #7404

  • Doc added/updated
  • Tests added

@tangledbytes tangledbytes changed the title fix #7404 Abide by RFC 7230 for S3 HTTP headers Jul 24, 2023
Copy link
Contributor

@liranmauda liranmauda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com>
@tangledbytes tangledbytes merged commit 6281591 into noobaa:master Jul 27, 2023
7 checks passed
@dannyzaken dannyzaken mentioned this pull request Aug 2, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NSFS | TypeError [ERR_INVALID_CHAR]: Invalid character in header content ["x-amz-meta-security.selinux"]
2 participants