Allow customizing keep-alive and request timeouts for endpoint servers #7419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@guymguym I haven't added any keepAliveEnabled because I think |
guymguym
approved these changes
Aug 1, 2023
|
@Utkarsh-pro perhaps add these configs to standalone.md too with recommended values for TMFS? |
guymguym
force-pushed
the
utkarsh-pro/temp/timout-work
branch
from
af33f3a
to
c9bf18b
Compare
|
@Utkarsh-pro Notice I rebased your branch (utkarsh-pro:utkarsh-pro/temp/timout-work) you will need to use "the force" to push/pull it to your clone |
tangledbytes
force-pushed
the
utkarsh-pro/temp/timout-work
branch
from
b6dfeb9
to
e2beee5
Compare
Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com> allow customizing keepAlive and request timeouts for endpoint servers Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com> remove test throttling Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com> add recommeded values to standalone doc Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com> allow customizing keepAlive and request timeouts for endpoint servers Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com> allow customizing keepAlive and request timeouts for endpoint servers Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com> remove test throttling Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com>
tangledbytes
force-pushed
the
utkarsh-pro/temp/timout-work
branch
from
e2beee5
to
31a2e2d
Compare
|
@guymguym, I have added 15 mins as request timeout (with 3 retries this should give us about 45 mins) and 1 minute as keep alive timeout for TMFS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
This PR adds 2 configurations to endpoints, the intention is to allow the users to configure these timeouts based on their environments. For example, in a case where a NooBaa deployment is behind a horribly excruciatingly slow VPN, in those cases the user might want to tweak these values.
NOTE: This still requires cooperation from the AWS client. So it is important for the client to use
--cli-read-timeoutand--cli-connect-timeout.Testing Instructions:
aws s3api --endpoint <val> put-object ...should run just fine provided the timeouts are correctly set.