BucketDiff is now checking for metadata change if the latest ETag is the same #7422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liranmauda
force-pushed
the
liran-bucket-diff-metadata
branch
from
4876daf
to
ce1b4c9
Compare
romayalon
approved these changes
Aug 2, 2023
… the same - bucket diff is now checking for metadata change if the latest ETag is the same - moved get_object_md from replication_utils into bucket_diff Signed-off-by: liranmauda <liran.mauda@gmail.com> s
liranmauda
force-pushed
the
liran-bucket-diff-metadata
branch
from
ce1b4c9
to
58b7201
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
###Gap:
The ETags are the same but it is not ensuring that the metadata is also the same
we might want to go over all of the same ETags and check for each version if the metadata is the same.
currently, we choose to treat multiple same Etag as the same object and slice to the latest we found.
Testing Instructions:
npx jest --testPathPattern="test_bucket_diff.test.js"