NSFS | MPU | optimization #7434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romayalon
force-pushed
the
romy-mpu-optimization
branch
3 times, most recently
from
8daded1
to
bdfc30b
Compare
liranmauda
approved these changes
Aug 8, 2023
romayalon
force-pushed
the
romy-mpu-optimization
branch
3 times, most recently
from
c99d6e7
to
617609a
Compare
romayalon
force-pushed
the
romy-mpu-optimization
branch
2 times, most recently
from
8955419
to
d33c756
Compare
guymguym
requested changes
Aug 22, 2023
src/sdk/namespace_fs.js
Outdated
Comment on lines
1420
to
1459
| let open_mode = 'r+'; | ||
| const md_open_mode = 'w+'; |
There was a problem hiding this comment.
we can add a single open mode if that can help here -
{ "w*", O_CREAT | O_RDWR },
There was a problem hiding this comment.
instead, what I did was to use * as truncate remover, let me know what you think
There was a problem hiding this comment.
I'd summon @eshelmarc to comment on that. WDYT on this mode. We don't want to truncate, but keep writing to the file in offsets that are multiplies of the part size. Romy said that O_APPEND is also not suitable so we wanted to open with just O_CREAT - Does this make sense?
romayalon
force-pushed
the
romy-mpu-optimization
branch
from
d33c756
to
f8f7697
Compare
guymguym
reviewed
Aug 24, 2023
guymguym
reviewed
Aug 24, 2023
guymguym
reviewed
Aug 24, 2023
guymguym
reviewed
Aug 24, 2023
romayalon
force-pushed
the
romy-mpu-optimization
branch
4 times, most recently
from
0e368bf
to
bf7b37b
Compare
romayalon
force-pushed
the
romy-mpu-optimization
branch
5 times, most recently
from
2741ae5
to
8917331
Compare
Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com>
romayalon
force-pushed
the
romy-mpu-optimization
branch
from
8917331
to
669d405
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
Issues: Fixed #xxx / Gap #xxx
Testing Instructions: