Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add #!/bin/bash header to bash files #7436

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

romayalon
Copy link
Contributor

Explain the changes

  1. The changed files were missing #!/bin/bash header which caused the following error while trying to build noobaa -
    Error while loading //./src/deploy/NVA_build/install_arrow_build.sh: Exec format error
    Fun Fact - it's called Shebang - https://en.wikipedia.org/wiki/Shebang_%28Unix%29

Issues: Fixed #xxx / Gap #xxx

Testing Instructions:

  • Doc added/updated
  • Tests added

Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com>
Copy link
Contributor

@alphaprinz alphaprinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@romayalon romayalon merged commit ec60f5e into noobaa:master Aug 8, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants