Migrating to AWS SDK V3 | Add AWS SDK V3 Wrapper #7442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guymguym
requested changes
Aug 16, 2023
shirady
force-pushed
the
noobaa-s3-client-wrapper
branch
from
ec2eac9
to
567ca29
Compare
guymguym
reviewed
Aug 17, 2023
shirady
force-pushed
the
noobaa-s3-client-wrapper
branch
2 times, most recently
from
1c5a464
to
54aa732
Compare
guymguym
approved these changes
Aug 18, 2023
guymguym
reviewed
Aug 20, 2023
guymguym
reviewed
Aug 20, 2023
shirady
force-pushed
the
noobaa-s3-client-wrapper
branch
from
e616d49
to
a516bb1
Compare
Signed-off-by: shirady <57721533+shirady@users.noreply.github.com>
shirady
force-pushed
the
noobaa-s3-client-wrapper
branch
from
a516bb1
to
1e0ac1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
Issues: Fixed #xxx / Gap #xxx
Testing Instructions:
Analyze resource
We use analyze resource with a change - we set the region to be the
config.DEFAULT_REGION, params as aws sdk v3 structure, and usenoobaa_s3_client.get_s3_client_v3_paramsfunction.Note:
nbis an alias that runs the local operator frombuild/_output/bin(alias created bydevenv).nb namespacestore create <aws-s3 or s3-compatible> <namespace-store-name>nb diagnostics analyze namespacestore <namespace-store-name>1 - s3-compatible - Noobaa bucket (with noobaa system as a server, the endpoint was taken from the field
InternalDNSunderS3 Addresses).2 - aws-s3 without flag region on a bucket in a region that is not 'us-east-1' (for example 'us-west-1').
To run jest tests:
npx jest test_noobaa_s3_client.test.jstest_noobaa_s3_client.test.js.