COPY OBJECT | OBJECT IO | Semaphore deadlock fix #7443
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
The problem -
A BZ reporting on a replication QE test failure was opened, during the BZ investigation 2 problems arose -
Some more details -
The memory of the endpoint pod was 500M and on large objects (~300MB and up) the replication was not successful due to semaphore timeouts.
The first semaphore timeout was thrown from read_object_stream(), but since we didn't awaited for the promise to be rejected/resolved there was an unhandled rejection, then, the upload_stream() part of the copy was stuck and never released the semaphore.
The fix -
Additional Suggestions -
Issues: Fixed #xxx / Gap #xxx
Testing Instructions: