Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating to AWS SDK V3 | Replace node-http-handler Package #7445

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

shirady
Copy link
Contributor

@shirady shirady commented Aug 16, 2023

Explain the changes

  1. @aws-sdk/node-http-handler was deprecated (here). I found it out through this aws/aws-sdk-ls-v3#4990.
  2. I run npm uninstall @aws-sdk/node-http-handler and npm install @smithy/node-http-handler .
  3. I changed the imports that already used this package from @aws-sdk/node-http-handler to @smithy/node-http-handler.

Issues: Fixed #xxx / Gap #xxx

  1. none.

Testing Instructions:

  1. none.
  • Doc added/updated
  • Tests added

@shirady shirady requested review from liranmauda, a team and vh05 and removed request for a team August 16, 2023 11:25
@shirady shirady self-assigned this Aug 16, 2023
@vh05
Copy link
Contributor

vh05 commented Aug 21, 2023

I am not sure about which is the stable version and what package we need to adopt.

Because @aws-sdk/node-http-handler package is marked under preview on aws-sdk documentation https://docs.aws.amazon.com/AWSJavaScriptSDK/v3/latest/preview/Package/-aws-sdk-node-http-handler/

@smithy/node-http-handler is the latest package available.
https://docs.aws.amazon.com/AWSJavaScriptSDK/v3/latest/Package/-smithy-node-http-handler/

The documentation is not really clear about what is what.

This link says that @smithy is rename to aws-sdk.

May be @dannyzaken @liranmauda can suggest better

@vh05 vh05 requested a review from dannyzaken August 21, 2023 06:55
@shirady
Copy link
Contributor Author

shirady commented Aug 21, 2023

Hi @v-harihar,
I'll try to respond to your comments:

I am not sure which is the stable version and what package we need to adopt.
Because @aws-sdk/node-http-handler package is marked under preview on aws-sdk documentation https://docs.aws.amazon.com/AWSJavaScriptSDK/v3/latest/preview/Package/-aws-sdk-node-http-handler/

The comment about preview is about the documentation API: "This AWS SDK API Reference for JavaScript v3 is in preview and is subject to change." and not about the package itself, the current version is this. Inside it you can see the package @smithy/node-http-handler (here).

@smithy/node-http-handler is the latest package available. https://docs.aws.amazon.com/AWSJavaScriptSDK/v3/latest/Package/-smithy-node-http-handler/

I agree, I also added in the description the PR that changed the packages.

The documentation is not really clear about what is what.
This link says that @smithy is rename to aws-sdk.

In the link, it says: "The @aws-sdk/node-http-handler package has become deprecated... Apparently it has now moved to the @smithy". It is fine, we move to use the package under smithy.

@dannyzaken @liranmauda I hope it is clear.

@shirady shirady force-pushed the replace-node-http-handler-package branch from 2cc25ce to 22e919a Compare August 21, 2023 12:45
@shirady shirady force-pushed the replace-node-http-handler-package branch from 22e919a to 9b39454 Compare August 21, 2023 14:11
run npm uninstall @aws-sdk/node-http-handler
run npm install @smithy/node-http-handler

Signed-off-by: shirady <57721533+shirady@users.noreply.github.com>
@shirady shirady force-pushed the replace-node-http-handler-package branch from 9b39454 to 7f54c70 Compare August 21, 2023 14:28
@shirady shirady merged commit 8f8e51a into noobaa:master Aug 21, 2023
7 checks passed
@shirady shirady deleted the replace-node-http-handler-package branch August 21, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants