Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI | NSFS Versioning | Increase Timeout for 7 Tests That Failed in the CI #7446

Merged

Conversation

shirady
Copy link
Contributor

@shirady shirady commented Aug 16, 2023

Explain the changes

  1. Increase timeout for 7 tests that failed in the CI.
  2. Those tests started to fail last week (inconsistency re-run the job solved it), for the first one the error is related to the timeout and I'm assuming the next failures are related.
  1. bucketspace namespace_fs - versioning
    delete multiple objects - versioning enabled
    delete multiple objects - no version id:
    Error: Timeout of 60000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/root/node_modules/noobaa-core/src/test/unit_tests/sudo_index.js)
    at listOnTimeout (node:internal/timers:569:17)
    at process.processTimers (node:internal/timers:512:7)

Issues: Fixed #xxx / Gap #xxx

  1. GAP - we will need to monitor that those tests pass consistently, in case this solution is not enough we would decrease the number of objects in the test (from hundreds to dozens).

Testing Instructions:

Run Unit Tests on a local machine:

  1. In file src/test/unit_tests/sudo_index.js leave only require('./test_bucketspace_versioning'); (rest of test files  comment out).
  2. From the core tab in the terminal run: make root-perm-test (You should see "144 passing" at the end of the output).
  • Doc added/updated
  • Tests added

Signed-off-by: shirady <57721533+shirady@users.noreply.github.com>
@shirady shirady self-assigned this Aug 16, 2023
@shirady shirady merged commit e23923d into noobaa:master Aug 16, 2023
7 checks passed
@shirady shirady deleted the change-nsfs-versioning-delete-objects-timeout branch August 16, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants