Migrating to AWS SDK V3 | Use AWS SDK V3 In Unit Tests (upgrade_script, dedup, lifecycle) #7457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shirady
force-pushed
the
migrate-aws-sdk-imp-unit-tests-part-1
branch
3 times, most recently
from
cbde633
to
9deffcd
Compare
|
|
shirady
force-pushed
the
migrate-aws-sdk-imp-unit-tests-part-1
branch
from
9deffcd
to
dfc3f46
Compare
dannyzaken
approved these changes
Sep 3, 2023
shirady
force-pushed
the
migrate-aws-sdk-imp-unit-tests-part-1
branch
from
dfc3f46
to
6eb942c
Compare
1. upgrade_scripts
2. dedup
3. lifecycle:
- pass Date as Date (not string)
- remove test of Filter {} since it is not allowed (Filter must have exactly one of Prefix, Tag, or And specified)
* remove call to commonTests.test_empty_filter (that was deleted)
Signed-off-by: shirady <57721533+shirady@users.noreply.github.com>
shirady
force-pushed
the
migrate-aws-sdk-imp-unit-tests-part-1
branch
from
6eb942c
to
f7032c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
Implementation of AWS SDK V3 (without wrapper) in unit tests:
Issues: Fixed #xxx / Gap #xxx
Testing Instructions:
make test(upgrade_script and lifecycle run as a part of the CI).