Migrating to AWS SDK V3 | Use AWS SDK V3 In Unit Tests (namespace_auth, bucketspace, bucketspace versioning) #7461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shirady
force-pushed
the
migrate-aws-sdk-imp-unit-tests-part-2
branch
from
872a8a1
to
0982b78
Compare
shirady
force-pushed
the
migrate-aws-sdk-imp-unit-tests-part-2
branch
from
0982b78
to
ebd5d10
Compare
shirady
changed the title
dannyzaken
approved these changes
Sep 3, 2023
1. namespace_auth 2. bucketspace: - In aws sdk v3 they do not deserialize empty arrays to save on memory allocation (for example: an empty bucket with listObjects would not have Content as an empty array, deleteObjects with no error would not have an empty Errors array, etc.). 3. bucketspace versioning Signed-off-by: shirady <57721533+shirady@users.noreply.github.com>
shirady
force-pushed
the
migrate-aws-sdk-imp-unit-tests-part-2
branch
from
ebd5d10
to
411fbba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
Implementation of AWS SDK V3 (without wrapper) in unit tests:
listObjectswould not haveContentas an empty array,deleteObjectswith no error would not have an emptyErrorsarray, etc.).Issues: Fixed #xxx / Gap #xxx
uploadwas not migrated to AWS SDK V3 (and still using AWS SDK V2).Testing Instructions:
The tests run as a part of the CI.
namespace_auth, bucketspace
make testbucketspace versioning
make root-perm-test