Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for SSL and connection string for Postgres client + SSL tests (2nd commit) #7464

Merged
merged 2 commits into from
Aug 30, 2023

Conversation

jackyalbo
Copy link
Contributor

@jackyalbo jackyalbo commented Aug 28, 2023

Explain the changes

  1. Adding support for SSL/TLS for working with an external Postgres DB. in case of adding env variable POSTGRES_SSL_REQUIRED
  2. Adding support for supporting self-signed server certificate, by using env variable POSTGRES_SSL_UNAUTHORIZED
  3. Adding support to work with client certificate - when located in /etc/external-db-secret (like for MGMT and S3)
  4. Adding support to work with a unified connection string (instead of providing host, dbname, port, and creds) with POSTGRES_CONNETION_STRING env variable

Testing:
5. Added docker builder to create an SSL-supported version for external PG (v15)
6. Added Makefile actions for building this docker image: build_ssl_postgres
7. Added Makefile for running sanity and unit test on top of the docker image for SSL Postgres
8. Added actions to run both sanity and unit test for SSL Postgres

Issues: Fixed #xxx / Gap #xxx

Testing Instructions:

  • Doc added/updated
  • Tests added

src/deploy/NVA_build/ssl_conf.sh Show resolved Hide resolved
src/util/postgres_client.js Show resolved Hide resolved
src/util/postgres_client.js Show resolved Hide resolved
Signed-off-by: jackyalbo <jacky.albo@gmail.com>
Signed-off-by: jackyalbo <jacky.albo@gmail.com>
@jackyalbo jackyalbo merged commit 0ca4a22 into noobaa:master Aug 30, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants