Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NotPrefix, NotAction and NotResource to bucket policy #7465

Merged
merged 1 commit into from
Sep 4, 2023
Merged

Add NotPrefix, NotAction and NotResource to bucket policy #7465

merged 1 commit into from
Sep 4, 2023

Conversation

nadavMiz
Copy link
Contributor

@nadavMiz nadavMiz commented Aug 29, 2023 •
edited

Explain the changes

  1. Add NotPrefix, NotAction and NotResource augments to bucket policy
    they can be used instead of the Prefix,Action,Resource counterparts

Issues: Fixed #xxx / Gap #xxx

  1. https://bugzilla.redhat.com/show_bug.cgi?id=2222487

Testing Instructions:

  1. add bucket policy with one of those arguments
  2. bucket policy should work
  • Doc added/updated
  • Tests added

@nadavMiz nadavMiz requested review from jackyalbo, a team and shirady and removed request for a team August 29, 2023 06:37
shirady
shirady reviewed Aug 29, 2023
View reviewed changes
src/api/common_api.js Outdated Show resolved Hide resolved
src/server/system_services/bucket_server.js Outdated Show resolved Hide resolved
src/endpoint/s3/s3_bucket_policy_utils.js Outdated Show resolved Hide resolved
src/test/unit_tests/test_s3_bucket_policy.js Outdated Show resolved Hide resolved
src/endpoint/s3/s3_bucket_policy_utils.js Show resolved Hide resolved
@nadavMiz nadavMiz force-pushed the not-actions-bucket-policy branch 3 times, most recently from a076a73 to ff99aae Compare August 30, 2023 12:31
jackyalbo
jackyalbo reviewed Sep 3, 2023
View reviewed changes
Copy link
Contributor

@jackyalbo jackyalbo left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In total, I think it looks good. If you can make the schema look a little bit better then great.

src/api/common_api.js Outdated Show resolved Hide resolved
src/api/common_api.js Show resolved Hide resolved
@nadavMiz nadavMiz force-pushed the not-actions-bucket-policy branch 2 times, most recently from df21749 to b776cf3 Compare September 3, 2023 13:42
@nadavMiz nadavMiz force-pushed the not-actions-bucket-policy branch 5 times, most recently from 12cb1fa to 308bbf6 Compare September 4, 2023 08:41
@nadavMiz
added NotPrefix, NotAction and NotResource to bucket policy
47d93c4 
Signed-off-by: nadav mizrahi <nadav.mizrahi16@gmail.com>
shirady
shirady approved these changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@shirady shirady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTIM

@nadavMiz nadavMiz merged commit e46f828 into noobaa:master Sep 4, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackyalbo jackyalbo jackyalbo approved these changes

@shirady shirady shirady approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nadavMiz @jackyalbo @shirady