Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrating to AWS SDK V3 | Use AWS SDK V3 In Unit Tests (s3_bucket_policy, s3_encryption, encryption) #7466

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Migrating to AWS SDK V3 | Use AWS SDK V3 In Unit Tests (s3_bucket_policy, s3_encryption, encryption) #7466

merged 1 commit into from
Sep 5, 2023

Conversation

shirady
Copy link
Contributor

@shirady shirady commented Aug 30, 2023 •
edited

Explain the changes

Implementation of AWS SDK V3 (without wrapper) in unit tests:

  1. s3_bucket_policy - In AWS SDK V3 there is no makeUnauthenticatedRequest, used workaround (we use a custom signer that returns the request as is (not modifying the request).
  2. s3_encryption
  3. encryption

Issues: Fixed #xxx / Gap #xxx

  1. In s3_encryption GAP - There are tests with TODO, I added the message we get with the new client.

Testing Instructions:

  1. make test (run as a part of the CI).
  • Doc added/updated
  • Tests added

@shirady shirady self-assigned this Aug 30, 2023
@shirady shirady force-pushed the migrate-aws-sdk-imp-unit-tests-part-3 branch from 0296fff to b2243e8 Compare September 3, 2023 06:45
@shirady shirady changed the title Migrating to AWS SDK V3 | Use AWS SDK V3 In Unit Tests (s3_bucket_policy, s3_encryption) Migrating to AWS SDK V3 | Use AWS SDK V3 In Unit Tests (s3_bucket_policy, s3_encryption, encryption) Sep 3, 2023
@shirady shirady force-pushed the migrate-aws-sdk-imp-unit-tests-part-3 branch 2 times, most recently from 465328e to dc1ad81 Compare September 5, 2023 06:31
@pull-request-size pull-request-size bot added size/XL and removed size/L labels Sep 5, 2023
@shirady shirady force-pushed the migrate-aws-sdk-imp-unit-tests-part-3 branch from dc1ad81 to 4757fae Compare September 5, 2023 06:32
@pull-request-size pull-request-size bot added size/L and removed size/XL labels Sep 5, 2023
@shirady shirady requested review from nadavMiz and removed request for jackyalbo September 5, 2023 08:14
nadavMiz
nadavMiz approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@nadavMiz nadavMiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirady
use aws sdk v3 in unit tests
5b452ca 
1. s3_bucket_policy - In AWS SDK V3 there is no makeUnauthenticatedRequest, used workaround.
2. s3_encryption
3. encryption

Signed-off-by: shirady <57721533+shirady@users.noreply.github.com>
@shirady shirady force-pushed the migrate-aws-sdk-imp-unit-tests-part-3 branch from 4757fae to 5b452ca Compare September 5, 2023 11:57
@shirady shirady merged commit 86ac6f9 into noobaa:master Sep 5, 2023
8 checks passed
@shirady shirady deleted the migrate-aws-sdk-imp-unit-tests-part-3 branch September 5, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nadavMiz nadavMiz nadavMiz approved these changes

@dannyzaken dannyzaken Awaiting requested review from dannyzaken

Assignees

@shirady shirady

Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shirady @nadavMiz