Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NC | NSFS | NSFS NC Systemd example script and docs for RPM installation #7469

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

romayalon
Copy link
Contributor

@romayalon romayalon commented Aug 30, 2023

Explain the changes

  1. Added systemd example script to the RPM build
  2. Added NC NSFS docs for RPM installation and build

Issues: Fixed #xxx / Gap #xxx

Testing Instructions:

  • Doc added/updated
  • Tests added

```

### Install NooBaa RPM -
Download the RPM to the machine and install it by running the following command -
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the command following this line would just install the RPM and not download it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tangledbytes Yes, it's just installation for now because I don't know where will the RPM be published.
@nimrod-becker @guymguym We need to discuss what RPM download instructions will look like,

  1. Where these RPMs are published?
  2. Will the RPM be based on our regular version branches?
  3. Will this RPM build be automated like DS/US builds?

@tangledbytes
Copy link
Member

One thing that slightly concerns me (not completely related to this PR) is that I added upgrade manager as part of RPM upgrades, so basically if a user already has NooBaa installed and then the install RPM for version 5.14.1 then our upgrade scripts will kick in and will do its thing. Now that's good but the issue would occur when there would be no postgresql to connect to (NSFS case) and upgrade_script would block (infinite loop) RPM install.

I think we should add a config which disable the upgrade manager. WDYT @romayalon @guymguym?

Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com>
@pull-request-size pull-request-size bot added size/L and removed size/M labels Aug 31, 2023
@romayalon romayalon merged commit 902284a into noobaa:master Aug 31, 2023
8 checks passed
@PravinRanjan10
Copy link
Collaborator

PravinRanjan10 commented Sep 11, 2023

Hi all, Posting the observation for tracking purpose:
Observations on Noobaa-service(nsfs):

  1. Systemctl start nsfs (Looks ok)
    Able to start the service, and basic CRUD on buckets done.

  2. Systemctl stop nsfs (looks like not smooth stop)
    ● nsfs.service - The NooBaa nsfs service.
    Loaded: loaded (/etc/systemd/system/nsfs.service; static; vendor preset: disabled)
    Active: failed (Result: exit-code) since Sun 2023-09-10 21:12:33 PDT; 1s ago
    Process: 1859288 ExecStop=/bin/kill QUIT $MAINPID (code=exited, status=64)
    Process: 1859279 ExecStart=/usr/local/node/bin/node /usr/local/noobaa-core/src/cmd/nsfs.js /tmp/test/ (code=killed, signal=TERM)
    Main PID: 1859279 (code=killed, signal=TERM)

  3. Systemctl enable nsfs [seems not working!!]
    [root@pr-ss1-worker-1 ~]# systemctl enable nsfs
    The unit files have no installation config (WantedBy, RequiredBy, Also, Alias
    settings in the [Install] section, and DefaultInstance for template units).
    This means they are not meant to be enabled using systemctl.
    Possible reasons for having this kind of units are:

    1. A unit may be statically enabled by being symlinked from another unit’s
      .wants/ or .requires/ directory.
    2. A unit’s purpose may be to act as a helper for some other unit which has
      a requirement dependency on it.
    3. A unit may be started when needed via activation (socket, path, timer,
      D-Bus, udev, scripted systemctl call, ...).
    4. In case of template units, the unit is meant to be enabled with some
      instance name specified.
  4. Systemctl disable nsfs [seems not working]

  5. Sometimes nsfs is in auto-start mode (specially, run enable and start)
    ● nsfs.service - The NooBaa nsfs service.
    Loaded: loaded (/etc/systemd/system/nsfs.service; static; vendor preset: disabled)
    Active: activating (auto-restart) (Result: exit-code) since Sun 2023-09-10 21:17:35 PDT; 1s ago
    Process: 1865942 ExecStart=/usr/local/node/bin/node /usr/local/noobaa-core/src/cmd/nsfs.js /tmp/test/ (code=exited, status=1/FAILURE)
    Main PID: 1865942 (code=exited, status=1/FAILURE) (edited)

@romayalon
Copy link
Contributor Author

@PravinRanjan10
Hey, this is just an example script, the install section is empty, have you tried my answer on slack?

@PravinRanjan10
Copy link
Collaborator

@PravinRanjan10 Hey, this is just an example script, the install section is empty, have you tried my answer on slack?

Okay. Edited the nsfs.service file and able to enable/disable the nsfs. But stop still looks failed!!.

@nimrod-becker
Copy link
Contributor

we'll look at stop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants