Build RPM - some fixes #7474
Merged
Build RPM - some fixes #7474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liranmauda
force-pushed
the
liran-remuve-redundent-node-download
branch
from
31dd410
to
3b32b2b
Compare
|
@tangledbytes If you can, please run it on your Linux, lets see that it work there as well 🙂 |
liranmauda
force-pushed
the
liran-remuve-redundent-node-download
branch
from
3b32b2b
to
b8f0cb0
Compare
- Removed redundant downloading for nodejs - Fix an issue when building the rpm target failed when PLATFORM was not set - Added the ability to provide the rep build image tag externally Signed-off-by: liranmauda <liran.mauda@gmail.com>
liranmauda
force-pushed
the
liran-remuve-redundent-node-download
branch
from
b8f0cb0
to
03321c7
Compare
tangledbytes
reviewed
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes