Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSFS | NC | S3 flow support #7475

Merged
merged 1 commit into from
Sep 4, 2023
Merged

Conversation

romayalon
Copy link
Contributor

Explain the changes

  1. create & delete bucket flows
  2. put/set/delete bucket policy
  3. set bucket versioning
  4. put/set/delete bucket website - wasn't tested
  5. put/set/delete bucket encryption - wasn't tested

Issues: Fixed #xxx / Gap #xxx

  1. TODO: add automatic nc system tests

Testing Instructions:

currently just manual tests -

  1. create account json under /path/to/config_dir/accounts/access_key.json
  2. run nsfs nc - sudo node src/cmd/nsfs /path/to/fs/root_path --config_root=/path/to/config_dir/
  3. alias s3-user='AWS_ACCESS_KEY_ID=access_key AWS_SECRET_ACCESS_KEY=secret_key aws --endpoint https://localhost:6443 --no-verify-ssl s3'
  4. s3-user mb/ls/cp etc
  5. s3-user api put-bucket-policy/put-bucket-versioning/delete-bucket etc
  • Doc added/updated
  • Tests added

@naveenpaul1
Copy link
Contributor

LGTM

@romayalon romayalon force-pushed the romy-nc-s3-flow branch 2 times, most recently from 657fa45 to a7a62f7 Compare September 4, 2023 09:43
Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com>
@romayalon romayalon merged commit 6f04744 into noobaa:master Sep 4, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants