Migrating to AWS SDK V3 | Implementation In Account Server and Bucket Server #7478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shirady
force-pushed
the
migrate-aws-sdk-imp-account-server-bucket-server
branch
from
f2f75b8
to
5d43f67
Compare
Neon-White
approved these changes
Sep 25, 2023
shirady
force-pushed
the
migrate-aws-sdk-imp-account-server-bucket-server
branch
2 times, most recently
from
a50ecb1
to
6ac906c
Compare
dannyzaken
approved these changes
Sep 26, 2023
1. Implementation of AWS SDK V3 in account server - check connection 2. Implementation of AWS SDK V3 in bucket server - check get cloud buckets 3. In the bucket server inside get_cloud_buckets changing deprecated P.fcall with resolve and reject promise to async-await with try-catch 3. Add missing action in AWS SDK V2 of listBuckets. 4. Update occurrences of deprecated functions in promise.js Signed-off-by: shirady <57721533+shirady@users.noreply.github.com>
shirady
force-pushed
the
migrate-aws-sdk-imp-account-server-bucket-server
branch
from
6ac906c
to
398a579
Compare
shirady
deleted the
migrate-aws-sdk-imp-account-server-bucket-server
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
listBuckets.get_cloud_bucketschanging deprecatedP.fcallwith promise chain to async-await with try-catch.Issues: Fixed #xxx / Gap #xxx
Testing Instructions:
Note:
nbis an alias that runs the local operator frombuild/_output/bin(alias created bydevenv).nb namespacestore create aws-s3 <namespace-store-name> --region=<target-bucket-region>.nb namespacestore create aws-s3 <namespace-store-name>nb namespacestore create s3-compatible <namespace-store-name>kubectl logs pod/noobaa-core-0the printings ofcheck_external_connection,get cloud buckets(easiest way is to search by the namespacestore name).