Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating to AWS SDK V3 | Implementation In BucketSpaceS3 (And nscache) #7481

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

shirady
Copy link
Contributor

@shirady shirady commented Sep 7, 2023

Explain the changes

  1. Implementation of AWS SDK V3 in BucketSpaceS3.
  2. Add the needed parameters of AWS SDK V3 in nscache script (the only use of BucketSpaceS3 today).
  3. Add missing actions in AWS SDK V2 of createBucket, deleteBucket, and headBucket.

Issues: Fixed #xxx / Gap #xxx

  1. none

Testing Instructions:

  1. none - nscache is not working today, I didn't test it.
  • Doc added/updated
  • Tests added

@shirady shirady self-assigned this Sep 7, 2023
@shirady shirady force-pushed the migrate-aws-sdk-imp-bucketspace-s3 branch 2 times, most recently from c6e707a to 2403cae Compare September 27, 2023 06:30
Signed-off-by: shirady <57721533+shirady@users.noreply.github.com>
@shirady shirady force-pushed the migrate-aws-sdk-imp-bucketspace-s3 branch from 2403cae to 3620e7d Compare September 27, 2023 14:08
@shirady shirady merged commit 2819e86 into noobaa:master Sep 27, 2023
8 checks passed
@shirady shirady deleted the migrate-aws-sdk-imp-bucketspace-s3 branch September 28, 2023 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants