Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NC | NSFS unit test #7483

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Conversation

naveenpaul1
Copy link
Contributor

Explain the changes

  1. Unit test for non-containerized NSFS

Issues: Fixed #xxx / Gap #xxx

Testing Instructions:

  1. local test : sudo node ./node_modules/mocha/bin/mocha src/test/unit_tests/test_bucketspace_multi_fs.js
  • Doc added/updated
  • Tests added

Copy link
Contributor

@romayalon romayalon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all in all looks good, few minor comments

src/test/unit_tests/test_bucketspace_multi_fs.js Outdated Show resolved Hide resolved
src/test/unit_tests/test_bucketspace_multi_fs.js Outdated Show resolved Hide resolved
src/test/unit_tests/test_bucketspace_multi_fs.js Outdated Show resolved Hide resolved
src/test/unit_tests/test_bucketspace_multi_fs.js Outdated Show resolved Hide resolved
Signed-off-by: naveenpaul1 <napaul@redhat.com>
@naveenpaul1 naveenpaul1 merged commit 317f20c into noobaa:master Sep 11, 2023
8 checks passed
@naveenpaul1 naveenpaul1 deleted the nc_nsfs_unit_test branch December 29, 2023 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants