Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed aws_usage_metering bg_worker #7492

Merged
merged 1 commit into from
Sep 14, 2023
Merged

removed aws_usage_metering bg_worker #7492

merged 1 commit into from
Sep 14, 2023

Conversation

dannyzaken
Copy link
Contributor

Explain the changes

  1. aws_usage_metering is an old BG worker that is not used anymore
  2. removed aws_usage_metering.js
  3. removed aws_usage_metering references in bg_workers and config.js

Issues: Fixed #xxx / Gap #xxx

Testing Instructions:

  • Doc added/updated
  • Tests added

jackyalbo
jackyalbo approved these changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@jackyalbo jackyalbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. maybe you also want to remove this line from standalone.md:

noobaa-core/docs/standalone.md

Line 173 in 0ca4a22

config.AWS_METERING_ENABLED = false;

@dannyzaken
removed aws_usage_metering bg worker
67a3d53 
Signed-off-by: Danny Zaken <dannyzaken@gmail.com>
@dannyzaken dannyzaken merged commit d75f741 into noobaa:master Sep 14, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackyalbo jackyalbo jackyalbo approved these changes

@nimrod-becker nimrod-becker Awaiting requested review from nimrod-becker

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dannyzaken @jackyalbo