[NC | NSFS] RPM Upgrades #7493
Merged
[NC | NSFS] RPM Upgrades #7493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tangledbytes
force-pushed
the
utkarsh/rpm/nsfs-upgrade
branch
2 times, most recently
from
6840428
to
f1a0a8d
Compare
romayalon
reviewed
Sep 27, 2023
|
Will update the PR once #7509 gets in. |
|
@tangledbytes I merged 7509 |
tangledbytes
force-pushed
the
utkarsh/rpm/nsfs-upgrade
branch
from
f1a0a8d
to
35610ac
Compare
romayalon
approved these changes
Sep 28, 2023
Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com> fix init upgrade Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com> fix pgrep command output Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com> address PR comments Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com>
tangledbytes
force-pushed
the
utkarsh/rpm/nsfs-upgrade
branch
from
35610ac
to
69355ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
This PR updates the RPM upgrades to add support for:
system.jsonunder/etc/noobaa.conf.dwhich holds the following data right now{ "current_version": "...", "upgrade_history": "[ ... ]" }which is created by thensfs.jsduring its first boot.Testing Instructions:
rpm -U <name>and you should see additional logs flowing in, ultimately the upgrade_manager should exit with zero exit code.