Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSFS | NC | nsfs health check #7499

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Conversation

naveenpaul1
Copy link
Contributor

@naveenpaul1 naveenpaul1 commented Sep 19, 2023

Explain the changes

  1. This PR will add a script to validate the nc nsfs health,
    eg:
    bash ./nc_nsfs_health.sh
    { "service_name": "nsfs", "status": "NOTOK", "memory": "", "checks": { "service": { "service_status": "activating", "pid": "0" }, "endpoint": { "endpoint_response": "000" }, } }

Issues: Fixed #xxx / Gap #xxx

  1. https://issues.redhat.com/browse/MCGI-170

Testing Instructions:

  1. run the bash command bash ./nc_nsfs_health.sh
  • Doc added/updated
  • Tests added

@naveenpaul1 naveenpaul1 marked this pull request as ready for review September 19, 2023 09:32
@naveenpaul1 naveenpaul1 changed the title nc nsfs health check NSFS | NC | nsfs health check Sep 19, 2023
src/deploy/nsfs.service Outdated Show resolved Hide resolved
tools/nc_nsfs_health.sh Outdated Show resolved Hide resolved
tools/nc_nsfs_health.sh Outdated Show resolved Hide resolved
tools/nc_nsfs_health.sh Outdated Show resolved Hide resolved
@romayalon
Copy link
Contributor

@naveenpaul1 please add a section of this health check in the docs :)

@naveenpaul1 naveenpaul1 force-pushed the nc_nsfs_health branch 2 times, most recently from 3e222a2 to 4d89a74 Compare September 25, 2023 05:56
@pull-request-size pull-request-size bot added size/L and removed size/M labels Sep 25, 2023
@naveenpaul1 naveenpaul1 force-pushed the nc_nsfs_health branch 3 times, most recently from 8c3fa3b to b4e20d3 Compare September 25, 2023 07:07
src/server/bg_services/semaphore_monitor.js Outdated Show resolved Hide resolved
src/cmd/health.js Show resolved Hide resolved
src/cmd/health.js Outdated Show resolved Hide resolved
src/cmd/health.js Outdated Show resolved Hide resolved
Signed-off-by: naveenpaul1 <napaul@redhat.com>
@naveenpaul1 naveenpaul1 merged commit e92e52c into noobaa:master Sep 26, 2023
8 checks passed
@naveenpaul1 naveenpaul1 deleted the nc_nsfs_health branch December 29, 2023 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants