Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Namespace GCP | Adding read_object_stream #7503

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Namespace GCP | Adding read_object_stream #7503

merged 1 commit into from
Sep 21, 2023

Conversation

liranmauda
Copy link
Contributor

Explain the changes

Namespace GCP | Adding read_object_stream

@liranmauda liranmauda force-pushed the liran-namespace-gcp10 branch 2 times, most recently from 7f77950 to 2a8fa8b Compare September 20, 2023 13:28
jackyalbo
jackyalbo approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@jackyalbo jackyalbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code itself looks good so approving. This code will be later tested and/or re-written.
I think maybe we should add a comment that this code is currently experimental.

@liranmauda
Namespace GCP | Adding read_object_stream
61f2dff 
Namespace GCP | Adding read_object_stream

Signed-off-by: liranmauda <liran.mauda@gmail.com>
@liranmauda liranmauda merged commit 18e67c4 into noobaa:master Sep 21, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackyalbo jackyalbo jackyalbo approved these changes

@dannyzaken dannyzaken Awaiting requested review from dannyzaken

@Neon-White Neon-White Awaiting requested review from Neon-White

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@liranmauda @jackyalbo