Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NSFS | NC | Small fixes and Docs updates #7505

Merged
merged 1 commit into from
Sep 28, 2023
Merged

NSFS | NC | Small fixes and Docs updates #7505

merged 1 commit into from
Sep 28, 2023

Conversation

romayalon
Copy link
Contributor

@romayalon romayalon commented Sep 21, 2023 •
edited

Explain the changes

  1. Add bucket creation date to the bucket.json config file on creation, date format - "creation_date":"2023-09-26T05:56:16.252Z"
  2. Stop object IO semaphore monitor prints
  3. Update NSFS non containerized docs

Issues: Fixed #xxx / Gap #xxx

  1. Fixed NSFS | NC | reoccurring object io is invalid error messages #7462

Testing Instructions:

  • Doc added/updated
  • Tests added

PravinRanjan10
PravinRanjan10 reviewed Sep 22, 2023
View reviewed changes
docs/non_containerized_NSFS.md Outdated Show resolved Hide resolved
docs/non_containerized_NSFS.md Show resolved Hide resolved
@PravinRanjan10
Copy link
Collaborator

May be UTC instead of GMT in creation_date.
Example:
"creation_date":"Thu Sep 21 2023 17:17:28 (UTC+0300)"

@romayalon
Copy link
Contributor Author

@PravinRanjan10 Thanks Pravin, I changed it to the following format -
"creation_date":"2023-09-26T05:56:16.252Z"

@romayalon romayalon force-pushed the romy-nsfs-nc-small-fixes branch 3 times, most recently from fde04f1 to a55ac27 Compare September 28, 2023 11:52
@romayalon
add bucket creation timestamp, stop object io monitor prints and upda…
3c12ff2 
…te docs

Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com>
@romayalon romayalon merged commit 78c283f into noobaa:master Sep 28, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PravinRanjan10 PravinRanjan10 PravinRanjan10 left review comments

@naveenpaul1 naveenpaul1 naveenpaul1 approved these changes

@tangledbytes tangledbytes Awaiting requested review from tangledbytes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NSFS | NC | reoccurring object io is invalid error messages
3 participants
@romayalon @PravinRanjan10 @naveenpaul1